Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34570 )
Change subject: cpu/x86/mp_init: Wait longer with serial enabled
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c@895
PS1, Line 895: CONSOLE_SERIAL
Several other platforms use CONSOLE_SERIAL, most don't have the problem you describe. This would than cause an unnecessary delay for other platforms, which is bad. Create a config SLOW_SERIAL_INIT, depending on CONSOLE_SERIAL, and use it here instead of CONSOLE_SERIAL. Also, add a description of the problem on the help line of this new config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id47df02a9238e66f2b628b9d6805858724bf30a9
Gerrit-Change-Number: 34570
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 25 Jul 2019 14:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment