Attention is currently required from: Paul Menzel, CK HU, Yu-Ping Wu.
Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44712 )
Change subject: soc/mediatek/mt8192: Get DDR base information after calibration
......................................................................
Patch Set 47:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44712/comment/213b877a_878834ef
PS46, Line 8:
Please paste the new log messages.
Done
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44712/comment/6fd1be26_d8c75a99
PS46, Line 3846: SPCMDRESP_MRR_RESPONSE
Align with &ch[chn]
Ack
https://review.coreboot.org/c/coreboot/+/44712/comment/fe11e1b1_211676e1
PS46, Line 3867: return value;
Please add a blank line above.
Ack
File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44712/comment/a246caa7_47477623
PS46, Line 57: 0x%#x
%#x
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie62948368716d309aab8149372b2b6093fc33552
Gerrit-Change-Number: 44712
Gerrit-PatchSet: 47
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: CK HU
ck.hu@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 06:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment