Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32023 )
Change subject: src: Use 'include <stdlib.h>' when appropriate
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/32023/12//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32023/12//COMMIT_MSG@12
PS12, Line 12: include <commonlib/stdlib.h>
Looking at the stat, this change seems to be more
about removing #includes. And I wonder what rules
were followed to do that? I know it's a huge effort
and there were probably already hours spent to
review this; but what do we gain from it? This
change seems to clean up some cases of indirect
includes while it creates some other?
If there is no automatic way to decide this, will
the cleanup ever end? or will we clean up our
cleanups forever in a loop?
https://review.coreboot.org/#/c/32023/12/src/arch/x86/include/arch/acpigen.h
File src/arch/x86/include/arch/acpigen.h:
https://review.coreboot.org/#/c/32023/12/src/arch/x86/include/arch/acpigen.h...
PS12, Line 168: size_t
what about this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id89751c600bad2ddb4b5aa9822adc5c5097787aa
Gerrit-Change-Number: 32023
Gerrit-PatchSet: 12
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 06 Apr 2019 16:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment