Attention is currently required from: Elyes Haouas, Jan Philipp Groß, Nicholas Chin, Riku Viitanen.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86055?usp=email )
Change subject: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061"
......................................................................
Patch Set 1: Code-Review-2
Copied votes on follow-up patch sets have been updated:
* Code-Review-2 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(1 comment)
Patchset:
PS1:
`#!!!!! Error: Undefined Symbol 'DRIVERS_ASMEDIA_ASPM_BLACKLIST' used at src/mainboard/asrock/z87_extreme4/Kconfig:8.`
No need to revert this when we can just change one line...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86055?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifbf895ff08bbb309cbb5236c1e5ff1f65f6e299e
Gerrit-Change-Number: 86055
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 19 Jan 2025 14:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes