Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41562 )
Change subject: [WIP] soc/amd/picasso/northbridge: implement map_oprom_vendev_rev
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41562/2/src/soc/amd/stoneyridge/nor...
File src/soc/amd/stoneyridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41562/2/src/soc/amd/stoneyridge/nor...
PS2, Line 562: map_oprom_vendev_rev
Why is this stoneyridge? Don't you mean picasso?
uh oh, seems that i messed something up here; not sure how this happened
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f48ecc3fbffddd21d1f830fbee26a09ac351e1c
Gerrit-Change-Number: 41562
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 May 2020 17:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment