Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later Nit: Update it as a single line comment.
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later Nit: Update it as a single line comment.
Otherwise LGTM.