Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39500 )
Change subject: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG@7 PS1, Line 7: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control 1. Please remove `src/` from the prefix. 2. The article *the* is not needed.
https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG@9 PS1, Line 9: Use the MCON and MCOF methods for camera clock control You can remove this, as it is the same as the commit message summary.
https://review.coreboot.org/c/coreboot/+/39500/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/39500/1/src/mainboard/intel/tglrvp/... PS1, Line 180: MCON(0,1) Please add a space after the comma.