Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37190 )
Change subject: soc/intel/common/cache_as_ram.S: Add macro to find a free MTRR ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/37190/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/37190/6/src/soc/intel/common/block/... PS6, Line 26: /* The comment looks rather weird now that the macro declaration isn't indented.
https://review.coreboot.org/c/coreboot/+/37190/6/src/soc/intel/common/block/... PS6, Line 35: put out
https://review.coreboot.org/c/coreboot/+/37190/6/src/soc/intel/common/block/... PS6, Line 161: find_free_mtrr Looks like the suggestions didn't reach this block