30 Jul
2019
30 Jul
'19
11:36 p.m.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34633 )
Change subject: soc/samsung/exynos5420: Refactor fimd vidtcon access ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
When doing the address arithmetic, this patch assumes there is an exynos_fb struct located at that higher address (as opposed to just the vidtcon variables). Do you know if this a safe assumption? I'm not quite sure of the memory layout.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34633
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13ed23836e8e9076ae0bfd88c05c4f2badac9c49
Gerrit-Change-Number: 34633
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jul 2019 21:36:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment