Attention is currently required from: Martin L Roth, Matt DeVillier, Paul Menzel, Felix Held.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68799 )
Change subject: Makefile.inc: Put site-local path first
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68799/comment/6c1b2aa4_07c629d5
PS2, Line 7: Makefile.inc: site-local path must go first
Please make the summary about the action: […]
Done
https://review.coreboot.org/c/coreboot/+/68799/comment/0ba85eff_2800f8e5
PS2, Line 10: used elsewhere in src/* makefiles. If we include it last src/*
: Makefile.inc will have already been processed. MAINBOARD_BLOBS_DIR is
: an example where the path needs to be overwritten in site-local
: requiring it to be included first before src/mainboard/* Makefile.inc
: is processed.
Please remove the trailing space.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ea865cd73aba5092a628b0422e5c4121b32fb4d
Gerrit-Change-Number: 68799
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 16 Nov 2022 19:43:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment