Attention is currently required from: Cliff Huang, Jérémy Compostella, Matt DeVillier, Subrata Banik.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85696?usp=email )
Change subject: intel/common/rtd3: Allow emitting PSD0 Method for PCH Root Ports
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/85696/comment/591ca232_c18fad0e?usp... :
PS5, Line 437: if (rp_type != PCIE_RP_PCH) {
Modphy gatting is supported only for PCIe root port under PCH in rtd3.c. […]
Interesting - thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85696?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia34cc1f9099ca88fa16a83174ec90ca14f43ab56
Gerrit-Change-Number: 85696
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sat, 11 Jan 2025 19:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com