Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36780 )
Change subject: nb/intel/sandybridge: Make the mainboard_early_init hook optional
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Not a fan of weak functions but let's just do this. We can
still try to figure out what hooks are really needed after
reducing the clutter.
https://review.coreboot.org/c/coreboot/+/36780/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/36780/1/src/northbridge/intel/sandy...
PS1, Line 219: callback
Nit: IMO, a hook, not a callback. As the nb code is never called from
mb level, how could it call*back*?.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62c8010aa81fc45d208e9293feb2f45b45f34a82
Gerrit-Change-Number: 36780
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 17 Nov 2019 13:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment