Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: lib/libpayload: Replace strapping_ids with new board configuration entry ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/include... File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/include... PS9, Line 111: UNDEFINED_FW_CONFIG
Agreed. As long as we have the payload check the invalid/undefined case, it should be fine. […]
Sure.
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c@a2... PS9, Line 222: if (bid == UNDEFINED_STRAPPING_ID)
Right. […]
I'll add a note in the commit msg; I think if this changes any payload's behavior, then there's a bug in the payload (it was depending on data without explicitly asking for it in coreboot).