Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47559 )
Change subject: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47559/3/src/drivers/intel/fsp2_0/ut... File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/47559/3/src/drivers/intel/fsp2_0/ut... PS3, Line 244: printk(BIOS_DEBUG, "%s not implemented.\n", __func__); Printing this on every FSP2.0 target is not a good idea. Having a Kconfig flag to indicate that a platform implements this functionality is better.