Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34599/9//COMMIT_MSG Commit Message:
PS9:
Some of the paragraphs might read better if you'd join them (generally, […]
Done
https://review.coreboot.org/c/coreboot/+/34599/9//COMMIT_MSG@19 PS9, Line 19: tested
double `tested`
Done
https://review.coreboot.org/c/coreboot/+/34599/9/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/34599/9/src/device/Kconfig@450 PS9, Line 450: It might not be implemented for every framebuffer initialization platform.
Can we drop this now?
Yes. Dropped
https://review.coreboot.org/c/coreboot/+/34599/9/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34599/9/src/lib/coreboot_table.c@15... PS9, Line 152: size_t
`size_t` only works if it has the same size as a pointer by coincidence. […]
Done
https://review.coreboot.org/c/coreboot/+/34599/9/src/lib/coreboot_table.c@15... PS9, Line 153: int
unsigned int?
Done