Attention is currently required from: Maxim Polyakov, Maximilian Brune, Paul Menzel, Sean Rhodes.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84633?usp=email )
Change subject: ec/starlabs/merlin: Add support for setting the charging speed
......................................................................
Patch Set 14: Code-Review+1
(3 comments)
File src/ec/starlabs/merlin/Kconfig:
https://review.coreboot.org/c/coreboot/+/84633/comment/80079c41_a3133d5e?usp... :
PS14, Line 69: EC_STARLABS_ITE
Commit message says Merlin
File src/ec/starlabs/merlin/ite.c:
https://review.coreboot.org/c/coreboot/+/84633/comment/cba766fb_24181a86?usp... :
PS14, Line 251: 0.C
Typo? `0.5C`
Also, what are the units?
https://review.coreboot.org/c/coreboot/+/84633/comment/5da8a0fc_5e31f3dc?usp... :
PS14, Line 263: 0
If I remember how the code works, this will fallback to `SPEED_1_0C`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84633?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46faa540530c5bd7f5473021561380213158152e
Gerrit-Change-Number: 84633
Gerrit-PatchSet: 14
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 06 Jan 2025 14:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes