Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47643 )
Change subject: soc/intel/tigerlake: Fix overlapping memory address used for early GSPI2 and UART bars
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47643/1/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47643/1/src/soc/intel/tigerlake/Kco...
PS1, Line 169: 0xfe03e000
I don't understand why we have the BAR defined in two different places: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/tigerlake/i...
Probably because it gets used by the payload as well. We might want to evaluate if there is a way to pass the address to the payload instead of using coreboot configs. Anyways, that would be for a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f2140a6dd21c2cb8d75823cc83cced0c660179
Gerrit-Change-Number: 47643
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Nov 2020 19:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment