Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/32731 )
Change subject: dp training: Always end with normal output
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32731/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32731/1//COMMIT_MSG@11
PS1, Line 11: suggested by Intel
Suggested where?
Any of these [1] that talk about the DP training sequence. Usually
in the "Display" volume, earlier along with the northbridge registers.
[1] https://01.org/linuxgraphics/documentation/hardware-specification-prms
https://review.coreboot.org/#/c/32731/1//COMMIT_MSG@14
PS1, Line 14:
Does this fix a bug or is it just to conform with the specification?
Done
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/32731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Ie1f19f2e1d1af62b402ad1dc41373d3d4437e976
Gerrit-Change-Number: 32731
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 May 2019 10:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment