Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )
Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... PS2, Line 3227: #define PCI_DEVICE_ID_INTEL_CMP_MMC 0x02c4
this could be PCI_DEVICE_ID_INTEL_CMP_EMMC just to make naming consistence across
Ack