mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32287 )
Change subject: lib/fmap: Add area read/write functions
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32287/1/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/#/c/32287/1/src/lib/fmap.c@194
PS1, Line 194: == -1)
Let's check for < 0 to be safe
Ack
https://review.coreboot.org/#/c/32287/1/src/lib/fmap.c@196
PS1, Line 196: (const void *)
What is this cast doing?
The cast is to satisfy the prototype in commonlib/region.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7669b8dc07b1aa5f00e7d8d0b1305b3de6c5949c
Gerrit-Change-Number: 32287
Gerrit-PatchSet: 1
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 18 Apr 2019 22:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment