Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47145 )
Change subject: sc7280: Limit SPI-NOR size ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47145/1/src/drivers/spi/stmicro.c File src/drivers/spi/stmicro.c:
https://review.coreboot.org/c/coreboot/+/47145/1/src/drivers/spi/stmicro.c@1... PS1, Line 192: .nr_sectors_shift = 11, What is this? Are you saying that the existing value for this chip is wrong? Because when the part is called N25Q256 that seems to indicate it is a 256Mbit (32MB) part, and according to my math 13 should then be the correct value here.