Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32373 )
Change subject: rockchip: rk3399: increase memory for fit payload. ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32373/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32373/2//COMMIT_MSG@7 PS2, Line 7: rockchip: rk3399: increase memory for fit payload. nit: Please be a little clearer about what you're changing and why, e.g.
rockchip/rk3399: Increase size reserved for ramstage to 2MB
This patch increases the size reserved for the ramstage in memlayout to 2MB because ...
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... File src/soc/rockchip/rk3399/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... PS2, Line 23: 16M Why would this need to change?
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... PS2, Line 24: 1100000 Why change the base address? (2M would've still easily fit where it was before.)