HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: src: cast *cbmem_top_chipset() function to uintptr_t
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43756/21/src/include/cbmem.h
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/43756/21/src/include/cbmem.h@60
PS21, Line 60: uintptr_t cbmem_top(void);
so you also change this ?
if so, please add it into commit msg.
you may also grep '*cbmem_top()' ...
https://review.coreboot.org/c/coreboot/+/43756/21/src/northbridge/intel/x4x/...
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/43756/21/src/northbridge/intel/x4x/...
PS21, Line 7: include <stdint.h>
please remove the one you added and keep the old one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12b105a5b49e2bbe2753a75eeff28fed29ee2297
Gerrit-Change-Number: 43756
Gerrit-PatchSet: 21
Gerrit-Owner: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment