Attention is currently required from: Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ......................................................................
Patch Set 6: Verified+1
(3 comments)
File util/cbfstool/cbfs.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135996): https://review.coreboot.org/c/coreboot/+/60233/comment/1ab5b610_e2de8d57 PS6, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135996): https://review.coreboot.org/c/coreboot/+/60233/comment/20a7bccc_706489ad PS6, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited before that close parenthesis ')'
File util/cbfstool/cbfs_image.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135996): https://review.coreboot.org/c/coreboot/+/60233/comment/8a40ccf7_5e960151 PS6, Line 89: if (((char *)entry) + be32toh(entry->offset) == hdr_loc) { braces {} are not necessary for single statement blocks