Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35643 )
Change subject: util/intelp2m: add Intel Pad to Macro util ......................................................................
Patch Set 20:
(3 comments)
Patch Set 16:
Do we need to add new macros to soc/intel/common/block/include/intelblocks/gpio_defs.h for NF and GPO that will take HS ownership into account? Or should we ignore the value in the HOSTSW_OWN_* registers for NF and GPO pads and use standard macros from gpio_defs.h?
I don't think we should be adding macros which do not really match the architecture expectations. I think it would be better to make the tool ignore ownership bits if pad is not GPI.
Ok. Currently, the utility ignores the ownership bits bit for pads configured as GPO and NF.
https://review.coreboot.org/c/coreboot/+/35643/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35643/16//COMMIT_MSG@10 PS16, Line 10: Sunrise
Sunrise Point
Done
https://review.coreboot.org/c/coreboot/+/35643/16//COMMIT_MSG@14 PS16, Line 14: h
k
Done
https://review.coreboot.org/c/coreboot/+/35643/19/util/intelp2m/parser/parse... File util/intelp2m/parser/parser.go:
https://review.coreboot.org/c/coreboot/+/35643/19/util/intelp2m/parser/parse... PS19, Line 89: // id : pad ID stirng
'stirng' may be misspelled - perhaps 'string'?
Done