Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )
Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2 ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33107/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/33107/1/src/lib/coreboot_table.c@28... PS1, Line 288: if (find_fmap_directory(&fmrd) == 0)
I'm confused... where are you mmaping the FMAP? Not in this code, right? Or am I missing something? […]
using FMAP_OFFSET instead
https://review.coreboot.org/c/coreboot/+/33107/1/src/lib/coreboot_table.c@31... PS1, Line 316: if (CONFIG(COMMON_CBFS_SPI_WRAPPER)) {
Shouldn't this check for BOOT_DEVICE_MEMORY_MAPPED instead?
Done
https://review.coreboot.org/c/coreboot/+/33107/1/src/lib/coreboot_table.c@32... PS1, Line 328: off
This is assuming the address returned by rdev_mmap() is a physical address. […]
introduced a new function rdev_mmio_addr()
https://review.coreboot.org/c/coreboot/+/33107/2/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/33107/2/src/lib/coreboot_table.c@29... PS2, Line 298: rdev_mmio_addr
I see what you are trying to do here, but I think it really confuses the point of the region/region […]
I tested on qemu and it works fine. I'll do tests on APL, but my understanding is that it should work on any memory mapped bootmedia.