[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Fine tune SD card D3 cold timing

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32552 )

Change subject: mb/google/sarien: Fine tune SD card D3 cold timing
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32552/1/src/mainboard/google/sarien/variants... 
File src/mainboard/google/sarien/variants/sarien/gpio.c:

https://review.coreboot.org/#/c/32552/1/src/mainboard/google/sarien/variants... 
PS1, Line 244: PAD_CFG_GPO(GPP_H12, 1, DEEP),
It is odd to set this twice in the same table, the timing is not going to be very long and it could be broken if the table were reordered or something added or removed.  Maybe put GPP_H12=1 into the regular "gpio_table" so it will get deasserted later in the boot.