23 Oct
2019
23 Oct
'19
2:17 p.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30811 )
Change subject: lib/prog_loaders.c: Add prog_locate_hook() ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30811/11/src/include/program_loadin... File src/include/program_loading.h:
https://review.coreboot.org/c/coreboot/+/30811/11/src/include/program_loadin... PS11, Line 146: * return -1
Please use CB_SUCCESS and friends.
In prog_locate() value 0 or -1 is returned. No friends of CB_SUCCESS. :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/30811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12207fc8f2e9ca45d048cf8c8d9c057f53e5c2c7
Gerrit-Change-Number: 30811
Gerrit-PatchSet: 11
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 12:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment