Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45574 )
Change subject: nb/intel/haswell: Use common MCHBAR accessor functions ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG@9 PS5, Line 9: baord board
https://review.coreboot.org/c/coreboot/+/45574/5//COMMIT_MSG@9 PS5, Line 9: remained I don't think this should be past tense. I generally write this as:
Tested with BUILD_TIMELESS=1, Lenovo ThinkPad T440p does not change.
I sometimes replace "does not change" with "remains identical". Feel free to use "lenovo/t440p" to refer to the mainboard, too.
https://review.coreboot.org/c/coreboot/+/45574/5/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/45574/5/src/northbridge/intel/haswe... PS5, Line 31: */ Please don't fuse these comments together.
One might as well drop these comments in a separate patch. They aren't useful.