17 Aug
2023
17 Aug
'23
8:46 a.m.
Attention is currently required from: Bill XIE.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77049?usp=email )
Change subject: haswell NRI: Collect SPD info ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2: Looks good other than the one question.
File src/northbridge/intel/haswell/native_raminit/spd_bitmunching.c:
https://review.coreboot.org/c/coreboot/+/77049/comment/325c6470_4acff8b9 : PS2, Line 79: channel + channel why is channel repeated?
--
To view, visit https://review.coreboot.org/c/coreboot/+/77049?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7948554eb02113bdca380222a11cfb322f9615f8
Gerrit-Change-Number: 77049
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE persmule@hardenedlinux.org
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Bill XIE persmule@hardenedlinux.org
Gerrit-Comment-Date: Thu, 17 Aug 2023 15:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment