Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage
......................................................................
Patch Set 29:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44196/7/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/44196/7/src/drivers/mrc_cache/mrc_c...
PS7, Line 384: cr = lookup_region(®ion, type);
nit: might be easier to just pass in *cr instead of type because all the callers already have that.
I think that we can clean this up at a later time, but with the timeline now to get this completed in the next couple of week, I'd like to push this CL in sooner rather than later if you're ok with that.
https://review.coreboot.org/c/coreboot/+/44196/8/src/mainboard/google/cyan/K...
File src/mainboard/google/cyan/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/8/src/mainboard/google/cyan/K...
PS8, Line 15: MRC_WRITE_NV_LATE
Increased the DRAM cache ram size to 0x5000 and it compiled. I still need to test this out.
Moving DRAM cache ram size bump to: https://review.coreboot.org/c/coreboot/+/45827/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3430bda45484cb8c2b01ab9614508039dfaac9a3
Gerrit-Change-Number: 44196
Gerrit-PatchSet: 29
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Sep 2020 17:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment