[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )

Change subject: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2 till 5
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
PS4, Line 42: 	switch (CONFIG_SA_PCIEX_LENGTH) {
> Seeing this, maybe it's a good idea to define PCIEXBAR_LENGTH index in Kconfig, and calculate the of […]

are you telling to have a if check before case ? we already have CONFIG_SA_PCIEXBAR_LENGTH_BIT_WIDTH and value >2 means more than 256MB length.