18 Mar
2020
18 Mar
'20
9:51 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38698 )
Change subject: vc/amd/fsp/picasso: Add PCIe and DDI helpers ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38698/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/38698/1/src/vendorcode/amd/fsp/pica... PS1, Line 37: GEN_MAX, // Maximum supported
It sometimes seems to depend on who's reviewing. I believe I've seen that requested to be omitted. […]
I would prefer a `GEN_MAX = 0` over the current `GEN1 = 1`
--
To view, visit https://review.coreboot.org/c/coreboot/+/38698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4d81a0f2909cb66e551e34e1f3fa4725560d60
Gerrit-Change-Number: 38698
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Mar 2020 16:51:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment