Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63484 )
Change subject: arch/x86/tables.c: Increase MAX_SMBIOS_SIZE ......................................................................
arch/x86/tables.c: Increase MAX_SMBIOS_SIZE
Systems have a lot more cores now and 4KiB is not cutting it. E.g. for a system with 255 cores more than 16KiB is needed.
We could also make this a Kconfig parameter but it's probably not worth having such micro optimizations to save a few KiB.
Change-Id: Idd47e55d8d679cc70eae996ee1af3ad7eaa1d0cc Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/tables.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/63484/1
diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c index 1018dce..8d2f7b6 100644 --- a/src/arch/x86/tables.c +++ b/src/arch/x86/tables.c @@ -142,7 +142,7 @@ { unsigned long high_table_pointer;
-#define MAX_SMBIOS_SIZE (4 * KiB) +#define MAX_SMBIOS_SIZE (32 * KiB)
high_table_pointer = (unsigned long)cbmem_add(CBMEM_ID_SMBIOS, MAX_SMBIOS_SIZE);