You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30975 )
Change subject: mediatek: Refactor I2C code among similar SOCs
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@41
PS11, Line 41: (
any reason to wrap these arguments with ()?
https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@58
PS11, Line 58: read
Would it be better if we rename this parameter to something like "mode"?
https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@241
PS11, Line 241: read
same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30975
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I407d5e2a9eb29562b40bb300e39f206a94afe76c
Gerrit-Change-Number: 30975
Gerrit-PatchSet: 11
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wang qii
Qii.Wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Fri, 14 Jun 2019 07:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
