Attention is currently required from: YH Lin, Paul Menzel, Nick Vaccaro.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59938 )
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59938/comment/f90266b9_70a0e21d
PS4, Line 9: Update
Add?
Done
https://review.coreboot.org/c/coreboot/+/59938/comment/b72aa3fc_5334fa6f
PS4, Line 10:
Which schematics version is that? Please add it to the commit message.
Added in commit message and also added bug number for schematic review for taniks.
Kindly please check.
File src/mainboard/google/brya/variants/taniks/gpio.c:
https://review.coreboot.org/c/coreboot/+/59938/comment/ba22f528_0b41af35
PS4, Line 153: * FPMCU not working after a S3 resume. This is a known issue.
Is there a bug report for that?
Sorry, my bad.
Taniks doesn't use HPS and FP.
The schematics reserved HPS and FP but will remove them in BOM.
I will set FP and HPS related pins to NC.
Sorry for causing misunderstanding.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 10 Dec 2021 01:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment