Attention is currently required from: Matt DeVillier, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options ......................................................................
Patch Set 2:
(6 comments)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/6e9d4e25_4c0a999f : PS1, Line 128: }
Actually more like `__pnp_002e_04->chip_info` and needs a cast, so probably […]
Thanks, I was looking for this but it was not obvious and I had no responses on IRC so I kinda gave up. Done
https://review.coreboot.org/c/coreboot/+/81426/comment/3d73820e_94bd29a6 : PS1, Line 274: s8 slope = conf->slope; : bool slope_neg = slope < 0;
Both should be `const` to show the intention.
Done
https://review.coreboot.org/c/coreboot/+/81426/comment/a1b870d9_f21b75ce : PS1, Line 369: #endif
If trying the 0 array length (see comment in `env_ctrl_chip.h`), this should […]
Done
File src/superio/ite/common/env_ctrl_chip.h:
https://review.coreboot.org/c/coreboot/+/81426/comment/8c6252ba_3adee81a : PS1, Line 106: #endif
As odd as it may seem, GCC accepts a `[0]` here (hopefully clang too). This […]
Done
File src/superio/ite/common/ite.h:
https://review.coreboot.org/c/coreboot/+/81426/comment/895e1fcb_0d0e38ca : PS1, Line 21: void ite_pme_out_disable(pnp_devfn_t dev);
The other APIs above have the verb first. So how about […]
Done
https://review.coreboot.org/c/coreboot/+/81426/comment/86ecb6b8_363675f1 : PS1, Line 26: #define ite_disable_3vsbsw(dev) ite_set_3vsbsw((dev), false)
Inline functions are preferred. e.g. […]
Done