17 Nov
2020
17 Nov
'20
3:49 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47490 )
Change subject: nb/intel/sandybridge: Clean up TC_OTHP writes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47490/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47490/2/src/northbridge/intel/sandy... PS2, Line 222: MCHBAR32_OR(addr, 0x00020000);
It's fundamentally wrong. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/47490
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a9076afec96e33cfdd12f9b78ca4101b3776dab
Gerrit-Change-Number: 47490
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 14:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment