[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Lenovo ThinkPad T440p

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )

Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................

Patch Set 8: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27 
PS3, Line 27: - Mainboard serial number is invalid
> I've found that the serial number is read via port 0x1630/0x1634, which is implemented in EmulatedEe […]

According to https://airbus-seclab.github.io/embedded_controller/BH2019-Slides-Breaking_T... 0x1630/0x1634 is just another EC interface as 0x62/0x66 is. However as 0x1600-0x1604 needs to be enabled using H8_CONFIG0_SMM_H8_ENABLE in reg H8_CONFIG0, there might be a similar bit for 0x1630/0x1634.