[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power...

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37604 )

Change subject: soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power idle
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37604/4/src/soc/intel/cannonlake/fi... 
File src/soc/intel/cannonlake/finalize.c:

https://review.coreboot.org/c/coreboot/+/37604/4/src/soc/intel/cannonlake/fi... 
PS4, Line 100: 		if (config->cppmvric2_adsposcdis) {
> suspect code indent for conditional statements (16, 16)

Done

https://review.coreboot.org/c/coreboot/+/37604/4/src/soc/intel/cannonlake/fi... 
PS4, Line 101: 		/* Enable Audio DSP OSC qualification for low power idle. */
             : 		reg32 = read32(pmcbase + CPPMVRIC2);
             : 		reg32 &= ~ADSPOSCDIS;
             : 		write32(pmcbase + CPPMVRIC2, reg32);
> Can you fix the indentation?

Done