Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33252 )
Change subject: security/tpm/tss/tcg-2.0: Add multi digits support to tlcl_extend() ......................................................................
Patch Set 4:
(4 comments)
Will upload new patchste
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tspi/tspi.... File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tspi/tspi.... PS4, Line 220: memcpy(tpml_digests.digests[0].digest.sha1, digest, sizeof(TPMU_HA));
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tspi/tspi.... PS4, Line 224: memcpy(tpml_digests.digests[0].digest.sha256, digest, sizeof(TPMU_HA));
line over 80 characters
Done
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2.... PS4, Line 288: /* : * This is a union, but as of now we support just one digest - sha256, so : * there is just one element. : */
The comment need to be updated.
Done
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2.... PS4, Line 294: invalidate_pcrs;
That's not part of spec right? Do we really need that?
Used for compare, but not needed anymore.