mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31325 )
Change subject: lenovo/g505s/Kconfig: Set framebuffer graphics mode to VESA 118h mode ......................................................................
Patch Set 4:
Patch set 4:
nobody else seems to enable this for default config so this raises some eyebrows here.
Maybe that's because the default config is using SeaBIOS and not GRUB. Personally I have not observed any differences while using this framebuffer 118h VESA option together with SeaBIOS. But this change could benefit those G505S owners who would like to use GRUB as the payload, so could be useful for some.
Your arguments sound as if this should be more globally enabled on default builds.
I think it should be decided for each board individually (don't know if this option could be as good/not-harmful for them, needs to be tested by those who are interested)