Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59260 )
Change subject: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59260/comment/567632ad_a46d09f6
PS3, Line 355: GPP_D16
I am a bit confused, which other place are we exposing D16 to driver ?
See line 324, which generates a separate power resource. We have reference counting built in to the driver to accomodate the fact that multiple PRs will each reference the same GPIOs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88ea1b87698c63e1bd69367ee857fba3f25c84ea
Gerrit-Change-Number: 59260
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arec
arec.kao@intel.com
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 22:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment