Attention is currently required from: Hung-Te Lin, Kenny Pan, Knox Chiou, Paul Menzel, Varshit Pandya, Yidi Lin, Yu-Ping Wu.
Kei Hiroyoshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81218?usp=email )
Change subject: mb/google/corsola: Add new board 'Kyogre' ......................................................................
Patch Set 7:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81218/comment/6267b5a6_9f1e91e5 : PS3, Line 7: mb/corsola/kyogre:
mb/google/corsola:
Done
https://review.coreboot.org/c/coreboot/+/81218/comment/71b075ab_7cd77e8b : PS3, Line 7: UPSTREAM: mb/corsola/kyogre: Add new board 'Kyogre'
Remove the UPSTREAM prefix since it's internal use only.
Done
https://review.coreboot.org/c/coreboot/+/81218/comment/ce40da37_57147ea8 : PS3, Line 9: Kinger
Kingler
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/81218/comment/b95b0d60_e1f3fdaf : PS4, Line 7: board
board variant
Done
https://review.coreboot.org/c/coreboot/+/81218/comment/6baf8a45_e3990549 : PS4, Line 9: follower
What does “follower” mean?
Kyogre is designed on the basis of Kingler.
https://review.coreboot.org/c/coreboot/+/81218/comment/bef44cf4_ddb5ed36 : PS4, Line 12: TEST=make # select Kyogre
As I remember, we verified image on Kyogre Proto unit with local build version. […]
Done
https://review.coreboot.org/c/coreboot/+/81218/comment/65207bf2_815739a0 : PS4, Line 14: Change-Id: Iae3857a9f8edadcc2eee3500fda2e76c0334221c
Please add a Signed-off-by line.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/81218/comment/3107facf_ace7fd5b : PS6, Line 20:
I would remove this extra line, also I'd put "signed-off" line after "Change-ID" […]
Done
Patchset:
PS7: Corrected as indicated.