Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47492 )
Change subject: nb/intel/sandybridge: Use arrays to program IOSAV ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_iosav.c:
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy... PS1, Line 32: ssq_count
Note: maybe keeping this and asserting at the start of this function that ssq_count != 0 is a good s […]
I specifically want to remove this assignment. A sequence doesn't get destroyed after executing it, so it can be run multiple times. Then, the only time ssq_count would be zero is if one tries to execute a sequence before programming any of the subsequence registers.
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy... PS1, Line 21: ssq_count
Should this be updated during the loop (use i) ?
d'oh, good catch