Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41809 )
Change subject: lib/coreboot_table: Add Intel FSP version to coreboot table
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41809/9/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/41809/9/src/lib/coreboot_table.c@53...
PS9, Line 538: #if CONFIG(FSP_ADD_VERSION_TO_CBMEM)
Please do the check in C and not the preprocessor.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92a13ca91b9f66a7517cfd6784f3f692ff34e765
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 10
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 16 Jun 2020 05:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment