Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32070 )
Change subject: mb/*/romstage: Drop defines already set by raminit code ......................................................................
Patch Set 4:
(3 comments)
I'd squash this with the previous patch
https://review.coreboot.org/#/c/32070/4/src/mainboard/asrock/h81m-hds/romsta... File src/mainboard/asrock/h81m-hds/romstage.c:
https://review.coreboot.org/#/c/32070/4/src/mainboard/asrock/h81m-hds/romsta... PS4, Line 77: : : : : : : : : : : : : : : not a sandy-bridge board, but haswell could benefit from the same changes ofc.
https://review.coreboot.org/#/c/32070/4/src/mainboard/google/slippy/variants... File src/mainboard/google/slippy/variants/falco/romstage.c:
https://review.coreboot.org/#/c/32070/4/src/mainboard/google/slippy/variants... PS4, Line 112: all these variants are haswell.
https://review.coreboot.org/#/c/32070/4/src/mainboard/supermicro/x10slm-f/ro... File src/mainboard/supermicro/x10slm-f/romstage.c:
https://review.coreboot.org/#/c/32070/4/src/mainboard/supermicro/x10slm-f/ro... PS4, Line 79: also a haswell board.