Attention is currently required from: Felix Singer. Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: mb/asus/sklkbl_h: Add base for Asus Skylake Boards ......................................................................
Patch Set 6:
(5 comments)
This change is ready for review.
File src/mainboard/asus/sklkbl_h/include/mainboard/gpio.h:
PS4:
Rename this file to variant/gpio.h to make clear that these methods are called from variants.
Done
https://review.coreboot.org/c/coreboot/+/48648/comment/dfb7c2ff_61c1f459 PS4, Line 6: mainboard_early_config_gpios
variant
Done
https://review.coreboot.org/c/coreboot/+/48648/comment/d706967a_8038b4e8 PS4, Line 6: void mainboard_early_config_gpios(void);
We already use variant_configure_early_gpios for other boards. […]
Might be a good idea to move these into common code. I'm not sure if the gpio_early function is actually needed on this one as UART is handled by the superio. Currently trying to figure that out and so far it seems to boot even without specifying gpios early.
https://review.coreboot.org/c/coreboot/+/48648/comment/9d0c9b0b_3d73ca29 PS4, Line 7: void mainboard_config_gpios(void);
variant
Done
File src/mainboard/asus/sklkbl_h/variants/h110t/board_info.txt:
https://review.coreboot.org/c/coreboot/+/48648/comment/0f404716_ae174c6d PS4, Line 1: Category: desktop : Vendor name: Asus
Remove
Done