Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35904 )
Change subject: soc/nvidia/tegra124: Fix null pointer and logic bug ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35904/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35904/1//COMMIT_MSG@13 PS1, Line 13:
Please duplicate the other commit message here.
Done
https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... File src/soc/nvidia/tegra124/spi.c:
https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... PS1, Line 291: if (dma) {
I might have done […]
Done
https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... PS1, Line 564: while ((read32(&spi->dma_out->regs->dma_byte_sta) < todo) ||
The value 'todo' changes here, so this commit is no longer just a NULL check. […]
This is the fix for the logic bug, which was copied from the previous commit.
https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... PS1, Line 566: spi_delay(spi, todo - spi_byte_count(spi));
I would like to see braces with this 'while'.
Done