Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32448 )
Change subject: soc/intel/apollolake/bootblock: Clear the GPI IS & IE registers
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32448/4/src/soc/intel/apollolake/bootblock/b...
File src/soc/intel/apollolake/bootblock/bootblock.c:
https://review.coreboot.org/#/c/32448/4/src/soc/intel/apollolake/bootblock/b...
PS4, Line 130: * interrupt storm during the kernel bootup.
It would be good to also mentioned that these registers do not get reset to default when booting back from S5.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b9d3bf08472219348e20b53bae470c589039fb
Gerrit-Change-Number: 32448
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 00:09:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment